PM-17418: added illustration icon and updated styles for Set master password screen #1310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| .foregroundStyle(Asset.Colors.textPrimary.swiftUIColor) | ||
| .styleGuide(.callout) | ||
| .multilineTextAlignment(.leading) | ||
| Image(asset: Asset.Images.Illustrations.lock) |
There was a problem hiding this comment.
🔨 Can you use the PageHeaderView here for this?
There was a problem hiding this comment.
that's really convenient, didn't know it exist.
Thanks!
|
Great job, no security vulnerabilities found in this Pull Request |
BitwardenShared/UI/Auth/SetMasterPassword/SetMasterPasswordAction.swift
Outdated
Show resolved
Hide resolved
BitwardenShared/UI/Auth/SetMasterPassword/SetMasterPasswordProcessor.swift
Outdated
Show resolved
Hide resolved
BitwardenShared/UI/Auth/SetMasterPassword/SetMasterPasswordProcessorTests.swift
Outdated
Show resolved
Hide resolved
BitwardenShared/UI/Auth/SetMasterPassword/SetMasterPasswordView.swift
Outdated
Show resolved
Hide resolved
BitwardenShared/UI/Auth/SetMasterPassword/SetMasterPasswordView.swift
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1310 +/- ##
==========================================
+ Coverage 89.45% 89.52% +0.07%
==========================================
Files 743 745 +2
Lines 46569 46642 +73
==========================================
+ Hits 41657 41758 +101
+ Misses 4912 4884 -28 ☔ View full report in Codecov by Sentry. |
matt-livefront
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-17418
📔 Objective
learn about ways to prevent account lockoutbutton for master password hint footer.📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes