8000 PM-16900: Update form card style for auth by matt-livefront · Pull Request #1326 · bitwarden/ios · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

PM-16900: Update form card style for auth #1326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 7, 2025

Conversation

matt-livefront
Copy link
Collaborator
@matt-livefront matt-livefront commented Feb 4, 2025

🎟️ Tracking

PM-16900

📔 Objective

Updates the card style background within the auth views.

📸 Screenshots

Before After
Screenshot 2025-02-04 at 4 33 17 PM Screenshot 2025-02-04 at 4 31 32 PM

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 97.41935% with 8 lines in your changes missing coverage. Please review.

Project coverage is 89.59%. Comparing base (117b15b) to head (ef350d8).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
BitwardenShared/UI/Auth/Landing/LandingView.swift 90.32% 3 Missing ⚠️
...I/Auth/Login/TwoFactorAuth/TwoFactorAuthView.swift 84.21% 3 Missing ⚠️
BitwardenShared/UI/Auth/Login/LoginView.swift 89.47% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1326      +/-   ##
==========================================
- Coverage   89.61%   89.59%   -0.02%     
==========================================
  Files         749      749              
  Lines       46980    46980              
==========================================
- Hits        42101    42093       -8     
- Misses       4879     4887       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor
github-actions bot commented Feb 4, 2025

Logo
Checkmarx One – Scan Summary & Details74b951fa-43ec-4266-b736-b863092bcb4b

Great job, no security vulnerabilities found in this Pull Request

Copy link
Member
@fedemkr fedemkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 LGTM, just one snapshot improvement.

@matt-livefront matt-livefront merged commit 20f43df into main Feb 7, 2025
9 checks passed
@matt-livefront matt-livefront deleted the matt/PM-16900-form-style-auth branch February 7, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None 42CA yet
Development

Successfully merging this pull request may close these issues.

2 participants
0