PM-17421: added icons to settings item view #1328
Conversation
|
Great job, no security vulnerabilities found in this Pull Request |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1328 +/- ##
=======================================
Coverage 89.61% 89.61%
=======================================
Files 749 749
Lines 46978 47004 +26
=======================================
+ Hits 42097 42121 +24
- Misses 4881 4883 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
🤔 Why did this snapshot change?
There was a problem hiding this comment.
I think this spacing caused the change
HStack(spacing: 12) {
There was a problem hiding this comment.
There's also a Spacer() in that HStack so we might be adding double spacing in that case. If you change the spacer to Spacer(minLength: 0) does this snapshot still change? Or remove the spacer and let the text expand with .frame(maxWidth: .infinity, alignment: .leading).
There was a problem hiding this comment.
Yeah just checked, if I change the spacer min length or frame, it does not break this test.
🎟️ Tracking
PM-17421
📔 Objective
SettingsListItem.📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes