QA-1070: Fixing broken textField accessibility IDs #1336
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1336 +/- ##
=======================================
Coverage 89.60% 89.60%
=======================================
Files 749 750 +1
Lines 47004 47035 +31
=======================================
+ Hits 42119 42148 +29
- Misses 4885 4887 +2 ☔ View full report in Codecov by Sentry. |
|
Great job, no security vulnerabilities found in this Pull Request |
BitwardenShared/UI/Platform/Application/Views/BitwardenTextField.swift
Show resolved
8000
Hide resolved
| /// After some investigation, we found that .id(..) needs to be the final modifier | ||
| /// to avoid breaking accessibilityIds used on our mobile automation test suite |
There was a problem hiding this comment.
⛏️ I'd move this just before the first TextField using the workaround given that it's not a comment for the whole property.
Additionally, from what I see .id(...) doesn't have to be the final modifier; it just needs to be after .accessibilityIdentifier(...), right?
There was a problem hiding this comment.
I rechecked it, and I found that the accessibilityId should also be set before the .hidden call, so I assume some other actions affect them (apart from setting an ID and hiding the element)
🎟️ Tracking
📔 Objective
This work is a subtask of QA-947, a story created to group all the native app views that contain elements without Automation IDs.
NOTE: Not all the elements will require an AutomationID. We are adding the ones we currently need so we can reduce the flakiness on some critical Mobile e2e tests
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes