8000 [PM-17935] Filtered out organization items on Credential Exchange export by fedemkr · Pull Request #1338 · bitwarden/ios · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[PM-17935] Filtered out organization items on Credential Exchange export #1338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

fedemkr
Copy link
Member
@fedemkr fedemkr commented Feb 10, 2025

🎟️ Tracking

PM-17935
PM-17936

📔 Objective

Filtered out organization items on Credential Exchange export as the SDK doesn't fully support them yet.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@fedemkr fedemkr changed the title [PM-17935] Filtered out organization items on Credential Exchange export [PM-17936] Filtered out organization items on Credential Exchange export Feb 10, 2025
@fedemkr fedemkr changed the title [PM-17936] Filtered out organization items on Credential Exchange export [PM-17935] Filtered out organization items on Credential Exchange export Feb 10, 2025
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details0d747a09-104f-405d-a718-b127a19263ba

Great job, no security vulnerabilities found in this Pull Request

Copy link
codecov bot commented Feb 10, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.60%. Comparing base (b15f660) to head (c52010f).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...ools/Repositories/ExportCXFCiphersRepository.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1338   +/-   ##
=======================================
  Coverage   89.60%   89.60%           
=======================================
  Files         750      750           
  Lines       47035    47035           
=======================================
  Hits        42148    42148           
  Misses       4887     4887           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fedemkr fedemkr merged commit 4e894eb into main Feb 10, 2025
9 checks passed
@fedemkr fedemkr deleted the PM-17935/export-passkey-filter-org branch February 10, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0