[PM-11135] Implemented Fido2 excluded credential logic for registration #1332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r a Fido2 credential.
|
Great job, no security vulnerabilities found in this Pull Request |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1332 +/- ##
==========================================
- Coverage 89.62% 89.60% -0.02%
==========================================
Files 750 751 +1
Lines 47072 47168 +96
==========================================
+ Hits 42187 42265 +78
- Misses 4885 4903 +18 ☔ View full report in Codecov by Sentry. |
...denShared/Core/Autofill/Models/ASAuthorizationPublicKeyCredentialDescriptor+Extensions.swift
Outdated
Show resolved
Hide resolved
BitwardenShared/UI/Vault/Vault/AutofillList/VaultAutofillListProcessor+Fido2Tests.swift
Outdated
Show resolved
Hide resolved
…ptor mapping to an init instead of a to...() method
matt-livefront
previously approved these changes
Feb 10, 2025
matt-livefront
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-11135
📔 Objective
When registering a Fido2 credential the RP can send data to determine whether the Fido2 provider has already a Fido2 credential for such RP so it's treated as an excluded credential and in order to prevent duplicates the user won't be able to register a new Fido2 credential for such RP + Username but they can open and see the current credential.
📸 Screenshots
Fido2.excluded.credentials.mov
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes