[PM-18049] Implemented Remove Unlock with Pin policy logic #1342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great job, no security vulnerabilities found in this Pull Request |
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #1342 +/- ##
=======================================
Coverage 89.63% 89.63%
=======================================
Files 754 754
Lines 47469 47497 +28
=======================================
+ Hits 42548 42574 +26
- Misses 4921 4923 +2 ☔ View full report in Codecov by Sentry. |
Comment on lines
2097
to
2120
| func test_logout_throwsWhenClearingPins() { | ||
| let account = Account.fixture() | ||
| stateService.accounts = [account] | ||
| stateService.activeAccount = account | ||
| vaultTimeoutService.isClientLocked[account.profile.userId] = false | ||
| biometricsRepository.capturedUserAuthKey = "Value" | ||
| biometricsRepository.setBiometricUnlockKeyError = nil | ||
| stateService.pinProtectedUserKeyValue["1"] = "1" | ||
| stateService.encryptedPinByUserId["1"] = "1" | ||
| policyService.policyAppliesToUserResult[.removeUnlockWithPin] = true | ||
|
|
||
| let task = Task { | ||
| try await subject.logout(userInitiated: true) | ||
| } | ||
| waitFor(!vaultTimeoutService.removedIds.isEmpty) | ||
| task.cancel() | ||
|
|
||
| XCTAssertEqual([account.profile.userId], stateService.accountsLoggedOut) | ||
| XCTAssertNil(biometricsRepository.capturedUserAuthKey) | ||
| XCTAssertEqual(keychainService.deleteItemsForUserIds, ["1"]) | ||
| XCTAssertTrue(stateService.logoutAccountUserInitiated) | ||
| XCTAssertEqual(vaultTimeoutService.removedIds, [anneAccount.profile.userId]) | ||
| XCTAssertNil(stateService.pinProtectedUserKeyValue["1"]) | ||
| XCTAssertNil(stateService.encryptedPinByUserId["1"]) |
There was a problem hiding this comment.
❓this seems same with test_logout_successWhenClearingPins.
There was a problem hiding this comment.
Nice catch it seems I forgot to include the throw result 🤦
| @@ -2094,30 +2094,28 @@ class AuthRepositoryTests: BitwardenTestCase { // swiftlint:disable:this type_bo | |||
| } | |||
|
|
|||
| /// `logout` successfully logs out a user clearing pins because of policy Remove unlock with pin being enabled. | |||
There was a problem hiding this comment.
🔨looks like this also needs to be updated.
Comment on lines
299
to
300
| /// Whether the policy to remove Unlock with pin feature is enabled. | ||
| var removeUnlockWithPinPolicyEnabled: Bool = false |
There was a problem hiding this comment.
⛏️ This state has the properties and computed properties separated - mind moving this up into the MARK: Properties section?
matt-livefront
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-18049
📔 Objective
Remove remove unlock with pin policy logic:
Note:
Given that we're currently hiding the "Unlock with Biometrics" setting when it's not available, then if this policy is enabled and "Unlock with Pin" is not shown, we need to also hide the section or it will show nothing under it.
📸 Screenshots
Remove Unlock with PIN policy enabled without PIN
Remove Unlock with PIN policy enabled without PIN nor Biometrics
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes