PM-17854: Add vault item type selection menu to FAB #1351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1351 +/- ##
==========================================
+ Coverage 89.64% 89.66% +0.02%
==========================================
Files 754 755 +1
Lines 47459 47519 +60
==========================================
+ Hits 42544 42608 +64
+ Misses 4915 4911 -4 ☔ View full report in Codecov by Sentry. |
|
Great job, no security vulnerabilities found in this Pull Request |
fedemkr
reviewed
Feb 13, 2025
Comment on lines
135
to
144
| /// - Parameters: | ||
| /// - addItem: The action to perform when a new cipher item type is tapped in the menu. | ||
| /// - addFolder: The action to perform when the new folder button is tapped in the menu. | ||
| /// - Returns: A `FloatingActionMenu` configured for adding a vault item for folder. | ||
| /// | ||
| func addVaultItemFloatingActionMenu( | ||
| hidden: Bool = false, | ||
| addItem: @escaping (CipherType) -> Void, | ||
| addFolder: (() -> Void)? = nil | ||
| ) -> some View { |
There was a problem hiding this comment.
⛏️ Missing hidden parameter docs.
Comment on lines
+30
to
+39
| var floatingActionButtonType: FloatingActionButtonType? { | ||
| switch group { | ||
| case .card, .identity, .login, .secureNote: | ||
| return .button | ||
| case .collection, .folder, .noFolder: | ||
| return .menu | ||
| case .sshKey, .totp, .trash: | ||
| return nil | ||
| } | ||
| } |
There was a problem hiding this comment.
🎨 Could we add a unit test for floatingActionButtonType
There was a problem hiding this comment.
Yep, added.
ezimet-livefront
approved these changes
Feb 14, 2025
fedemkr
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-17854
📔 Objective
This moves the vault item type selection menu from the vault add/edit screen and integrates it with the FAB in the vault list.
📸 Screenshots
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-02-13.at.13.47.27.mp4
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes