PM-17720: Adjusted button width on check email screen #1367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1367 +/- ##
==========================================
- Coverage 89.70% 89.70% -0.01%
==========================================
Files 756 756
Lines 47743 47742 -1
==========================================
- Hits 42828 42827 -1
Misses 4915 4915 ☔ View full report in Codecov by Sentry. |
| @@ -50,15 +50,15 @@ struct CheckEmailView: View { | |||
| openURL(URL(string: "message://")!) | |||
| } | |||
| .accessibilityIdentifier("OpenEmailAppButton") | |||
| .padding(.horizontal, 50) | |||
| .padding(.horizontal, -8) | |||
There was a problem hiding this comment.
🎨 It'd be better if we didn't use negative padding. If this needs to extend closer to the edge, we should adjust the padding on the scroll view (i.e. .scrollView(padding: 12)).
|
Great job, no security vulnerabilities found in this Pull Request |
matt-livefront
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-17720
📔 Objective
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes