[PM-15149] Remove ssh feature flag #1371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great job, no security vulnerabilities found in this Pull Request |
dbc4500 to
033e5f0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1371 +/- ##
=======================================
Coverage 89.58% 89.59%
=======================================
Files 767 767
Lines 48206 48194 -12
=======================================
- Hits 43187 43179 -8
+ Misses 5019 5015 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fedemkr
reviewed
Feb 21, 2025
| @@ -908,19 +900,16 @@ class DefaultVaultRepository { // swiftlint:disable:this type_body_length | |||
| let typesIdentityCount = activeCiphers.lazy.filter { $0.type == .identity }.count | |||
| let typesLoginCount = activeCiphers.lazy.filter { $0.type == .login }.count | |||
| let typesSecureNoteCount = activeCiphers.lazy.filter { $0.type == .secureNote }.count | |||
| let typesSshKeyCount = activeCiphers.lazy.filter { $0.type == .sshKey }.count | |||
<
8000
div hidden="hidden" data-view-component="true" class="js-comment-show-on-error flash flash-error flash-full">
There was a problem hiding this comment.
⛏️ Format on Ssh to SSH to follow swift guidelines:
Suggested change
| let typesSshKeyCount = activeCiphers.lazy.filter { $0.type == .sshKey }.count | |
| let typesSSHKeyCount = activeCiphers.lazy.filter { $0.type == .sshKey }.count |
fedemkr
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-15149
📔 Objective
Removes the featureflag that toggles whether ssh keys are displayed in the iOS app. This feature is rolled out on cloud now.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes