[PM-8222] New device verification page fixes #1381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great job, no security vulnerabilities found in this Pull Request |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1381 +/- ##
==========================================
- Coverage 89.66% 89.66% -0.01%
==========================================
Files 765 765
Lines 48016 48024 +8
==========================================
+ Hits 43055 43061 +6
- Misses 4961 4963 +2 ☔ View full report in Codecov by Sentry. |
fedemkr
approved these changes
Feb 25, 2025
| @@ -93,7 +93,7 @@ final class TwoFactorAuthProcessor: StateProcessor<TwoFactorAuthState, TwoFactor | |||
| state.toast = newValue | |||
| case let .verificationCodeChanged(newValue): | |||
| state.verificationCode = newValue | |||
| state.continueEnabled = (newValue.count >= 6) | |||
| state.continueEnabled = newValue.count >= (state.deviceVerificationRequired ? 8 : 6) | |||
There was a problem hiding this comment.
♻️ Maybe for another PR and it's something really minor but I'd extract (state.deviceVerificationRequired ? 8 : 6) to a private computed property that returns the minimum characters so to keep the logic simple here.
andrebispo5
added a commit
that referenced
this pull request
Feb 25, 2025
(cherry picked from commit e29448f)
andrebispo5
added a commit
that referenced
this pull request
Feb 25, 2025
andrebispo5
added a commit
that referenced
this pull request
Feb 25, 2025
(cherry picked from commit e29448f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-8222
📔 Objective
When device needs verification:
Verify your identityInvalid verification codewhen the verification code is invalid.📸 Screenshots
Title fix:
Continue button enabled:
Error message:
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes