[PM-18412] Update libraries in Authenticator #1396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great job, no security vulnerabilities found in this Pull Request |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1396 +/- ##
=======================================
Coverage 89.67% 89.67%
=======================================
Files 765 766 +1
Lines 48082 48108 +26
=======================================
+ Hits 43117 43143 +26
Misses 4965 4965 ☔ View full report in Codecov by Sentry. |
fedemkr
approved these changes
Feb 27, 2025
There was a problem hiding this comment.
LGTM 🎉 . In case anyone else checks this out we talked it internally with Katherine and all the Fido2 stuff were added to expedite and simplify the update of the SDK to be equal as what we have in Password manager app. At a later point this will be further simplify putting the common objects in shared library for the apps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-18412
📔 Objective
Before fully bringing in
Authenticatorinto theBitwardenworkspace, it needs its library dependencies to be on the same versions as the Password Manager. This makes that update.The particularly complicated part is that this also updates the SDK, which had breaking changes in the interim. Several additional files and modifications were needed to accommodate this. On the whole, these copies were done naïvely; further analysis and rationalization is better done when eventually consolidating files into
BitwardenKit, in my opinion.I ultimately wanted to put all this in a separate PR from the actual "add Authenticator to the workspace" to try to cut down on noise one way or the other.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes