8000 [PM-18656] Sync with bitwarden/template by vvolkgang · Pull Request #1397 · bitwarden/ios · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[PM-18656] Sync with bitwarden/template #1397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 27, 2025
Merged

[PM-18656] Sync with bitwarden/template #1397

merged 1 commit into from
Feb 27, 2025

Conversation

vvolkgang
Copy link
Member

🎟️ Tracking

PM-18656

📔 Objective

Update bitwarden/template common file. SECURITY.md was the only in need of an update, also checked the PR template, Issues config.yml and contributing.md.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsb04ea288-5110-4f2d-a590-2df8dfae6430

Great job, no security vulnerabilities found in this Pull Request

Copy link
codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.67%. Comparing base (2ad7702) to head (15bbfd2).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1397   +/-   ##
=======================================
  Coverage   89.67%   89.67%           
=======================================
  Files         766      766           
  Lines       48108    48108           
=======================================
+ Hits        43140    43143    +3     
+ Misses       4968     4965    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vvolkgang vvolkgang merged commit 217d2d2 into main Feb 27, 2025
9 checks passed
@vvolkgang vvolkgang deleted the sync-template branch February 27, 2025 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0