[PM-18412] Add Authenticator to Workspace #1402
Conversation
|
Great job, no security vulnerabilities found in this Pull Request |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1402 +/- ##
==========================================
- Coverage 89.67% 85.88% -3.80%
==========================================
Files 766 984 +218
Lines 48109 58369 +10260
==========================================
+ Hits 43141 50128 +6987
- Misses 4968 8241 +3273 ☔ View full report in Codecov by Sentry. |
| @@ -1,4 +1,4 @@ | |||
| #!/bin/bash | |||
|
|
|||
| PATH=/usr/local/bin:$PATH | |||
| ./Scripts-bwa/bootstrap.sh | |||
| ./Scripts/bootstrap.sh | |||
There was a problem hiding this comment.
🤔 Now that they're calling the main bootstrap.sh, anything stopping us from deleting the Scripts-bwa folder? No need to do it now if planned for another PR, just curious based on these changes.
There was a problem hiding this comment.
There are some other things still being called in there, I think—particularly build.sh—so I'd rather wait for another PR once we get things in the workflows a little more unified
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-18412
📔 Objective
This adds the
Authenticatorproject to theBitwardenWorkspace. It also does a bit of housekeeping around that, such as removingNetworkingSPM definitions, adjusting dependencies around, and updating some scripts accordingly.Further work for centralizing shared code will start in #1379 for test code and then continue in further PRs.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes