🍒 PM-17634 - Update When The App Checks If Authenticator Sync is Enabled #1455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great job, no security vulnerabilities found in this Pull Request |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/2025.03-rc7 #1455 +/- ##
====================================================
Coverage 89.58% 89.58%
====================================================
Files 767 767
Lines 48196 48198 +2
====================================================
+ Hits 43177 43179 +2
Misses 5019 5019 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
matt-livefront
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-17634
📔 Objective
Cherry pick of https://github.com/bitwarden/ios/pull/1448 into the release branch
Previously, when launching the app on a fresh install, we checked the feature flags for bitwarden.com before attempting to start the AuthenticatorSyncService. If the feature flag was initially disabled, the sync service would never start. This led to an issue where users logging into a self-hosted server—which has the feature flag enabled (
enable-pm-bwa-sync)—would not see sync events during that session, even if logging into a server that has the flag on. This caused the service to only start syncing after a full app restart which then had a fresh value for the feature flag.Added the check to be inside of
determineSyncForUserId(userId:)which is called from both Tasks within thestartfunction. This change ensures that the sync service always starts but dynamically guards data emission based on the feature flag’s state. This allows the service to respond immediately when the flag is enabled, without requiring an app restart.⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes