8000 [PM-19614] Fix Import Success Typo by nthompson-bitwarden · Pull Request #1466 · bitwarden/ios · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[PM-19614] Fix Import Success Typo #1466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 27, 2025

Conversation

nthompson-bitwarden
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-19614

📔 Objective

Replaces all instances of "Vertification" with "Verification"

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
codecov bot commented Mar 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.94%. Comparing base (a7c3752) to head (0531828).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1466       +/-   ##
===========================================
- Coverage   89.55%   68.94%   -20.62%     
===========================================
  Files         769      247      -522     
  Lines       48386    11213    -37173     
===========================================
- Hits        43334     7731    -35603     
+ Misses       5052     3482     -1570     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details1c21086f-0838-4b78-b497-ff98ff02542f

Great job, no security vulnerabilities found in this Pull Request

phil-livefront
phil-livefront previously approved these changes Mar 27, 2025
@phil-livefront phil-livefront self-requested a review March 27, 2025 17:28
@nthompson-bitwarden nthompson-bitwarden merged commit 969cf4b into main Mar 27, 2025
10 checks passed
@nthompson-bitwarden nthompson-bitwarden deleted the ned/PM-19614-import-verification-typo-fix branch March 27, 2025 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0