10000 [PM-19046] Update README - Adding Screenshots, workflow badges and Authenticator app references by vvolkgang · Pull Request #1461 · bitwarden/ios · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[PM-19046] Update README - Adding Screenshots, workflow badges and Authenticator app references #1461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 26, 2025

Conversation

vvolkgang
Copy link
Member
@vvolkgang vvolkgang commented Mar 25, 2025

🎟️ Tracking

PM-19046

📔 Objective

Aligns our README with other repos like bitwarden/clients by adding app screenshots, workflow badges and referring the Authenticator app.

Light and Dark themed screenshots that change depending on the active GitHub theme (links: github blog, github discussion, stackoverflow)

📸 Screenshots

Light Theme Dark Theme
Screenshot_light_theme Screenshot_dark_theme

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
codecov bot commented Mar 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.77%. Comparing base (a5bd7cf) to head (dd876e9).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1461      +/-   ##
==========================================
- Coverage   89.55%   85.77%   -3.78%     
==========================================
  Files         767      983     +216     
  Lines       48254    58452   +10198     
==========================================
+ Hits        43212    50139    +6927     
- Misses       5042     8313    +3271     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details4f84e22d-1f11-462a-b020-082ee5ddca28

Great job, no security vulnerabilities found in this Pull Request

andrebispo5
andrebispo5 previously approved these changes Mar 26, 2025
@vvolkgang vvolkgang changed the title [PM-19046] README Update - Adding Screenshots, workflow badges and Authenticator app references [PM-19046] Update README - Adding Screenshots, workflow badges and Authenticator app references Mar 26, 2025
@vvolkgang vvolkgang merged commit f2f9774 into main Mar 26, 2025
12 checks passed
@vvolkgang vvolkgang deleted the update-readme branch March 26, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0