8000 [PM-19507] deps: Updated SDK to ce330bb by fedemkr · Pull Request #1462 · bitwarden/ios · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[PM-19507] deps: Updated SDK to ce330bb #1462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 27, 2025
Merged

Conversation

fedemkr
Copy link
Member
@fedemkr fedemkr commented Mar 26, 2025

🎟️ Tracking

PM-19507

📔 Objective

Updated SDK to ce330bb3cb873c47041eb0e86f5c065b8799caa2.
Including CipherPermissions in cipher change and also updating to use CipherListView with Fido2 flows.

This also fixes an issue when compiling Authenticator app in Debug throwing "mint: command not found" on Scripts-bwa/update_acknowledgements.sh.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@fedemkr fedemkr changed the title [PM-19507] Updated SDK to ce330bb [PM-19507] deps: Updated SDK to ce330bb Mar 26, 2025
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsea4a3d66-0c7c-4e1f-b6b7-f8439f0630d3

Great job, no security vulnerabilities found in this Pull Request

Copy link
codecov bot commented Mar 26, 2025

Codecov Report

Attention: Patch coverage is 80.95238% with 8 lines in your changes missing coverage. Please review.

Project coverage is 85.78%. Comparing base (336e8dc) to head (a78f5c5).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...red/Core/Vault/Extensions/BitwardenSdk+Vault.swift 58.33% 5 Missing ⚠️
...lt/PreviewContent/BitwardenSdk+VaultFixtures.swift 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1462      +/-   ##
==========================================
- Coverage   89.56%   85.78%   -3.79%     
==========================================
  Files         769      981     +212     
  Lines       48363    58511   +10148     
==========================================
+ Hits        43318    50194    +6876     
- Misses       5045     8317    +3272     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fedemkr fedemkr merged commit a7c3752 into main Mar 27, 2025
12 checks passed
@fedemkr fedemkr deleted the PM-19507/update-sdk-ce330bb branch March 27, 2025 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0