[PM-19542] Add flight recorder feature flag #1472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great job, no security vulnerabilities found in this Pull Request |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1472 +/- ##
=======================================
Coverage 89.56% 89.56%
=======================================
Files 769 769
Lines 48391 48392 +1
=======================================
+ Hits 43341 43342 +1
Misses 5050 5050 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fedemkr
reviewed
Mar 28, 2025
| @@ -116,6 +119,7 @@ enum FeatureFlag: String, CaseIterable, Codable { | |||
| switch self { | |||
| case .enableCipherKeyEncryption, | |||
| .enableDebugAppReviewPrompt, | |||
| .flightRecorder, | |||
There was a problem hiding this comment.
🤔 Shouldn't this be able to be remotely configured?
There was a problem hiding this comment.
I think we've been waiting until the feature is complete before allowing it to be remotely configured.
There was a problem hiding this comment.
Oh yes makes sense so server side can't enable a non-finished feature; thanks for explaining. Approving.
fedemkr
approved these changes
Mar 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-19542
📔 Objective
Adds the feature flag for the flight recorder.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes