8000 [BWA-155] Move DefaultHeadersRequestHandler to BitwardenKit by KatherineInCode · Pull Request #1473 · bitwarden/ios · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[BWA-155] Move DefaultHeadersRequestHandler to BitwardenKit #1473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 31, 2025

Conversation

KatherineInCode
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/BWA-155

📔 Objective

To help lay more groundwork for BWA Remote Feature Flags, this moves DefaultHeadersRequestHandler into BitwardenKit.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
codecov bot commented Mar 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.78%. Comparing base (405073a) to head (796311c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1473      +/-   ##
==========================================
- Coverage   89.56%   85.78%   -3.78%     
==========================================
  Files         769      981     +212     
  Lines       48392    58520   +10128     
==========================================
+ Hits        43344    50204    +6860     
- Misses       5048     8316    +3268     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsb934a6fc-5c48-4e53-bd76-72696d598fcf

Great job, no security vulnerabilities found in this Pull Request

@KatherineInCode KatherineInCode marked this pull request as ready for review March 31, 2025 18:04
@KatherineInCode KatherineInCode merged commit faff479 into main Mar 31, 2025
12 checks passed
@KatherineInCode KatherineInCode deleted the bwa-155/default-headers-consolidation branch March 31, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0