[BWA-155] Copy reduced APIService and EnvironmentService into AuthenticatorShared #1504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1504 +/- ##
==========================================
- Coverage 89.66% 85.86% -3.80%
==========================================
Files 781 991 +210
Lines 48815 58987 +10172
==========================================
+ Hits 43768 50648 +6880
- Misses 5047 8339 +3292 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Great job, no security vulnerabilities found in this Pull Request |
vvolkgang
previously approved these changes
Apr 16, 2025
vvolkgang
approved these changes
Apr 16, 2025
fedemkr
approved these changes
Apr 16, 2025
Comment on lines
+40
to
+45
| defaultHeadersRequestHandler = DefaultHeadersRequestHandler( | ||
| appName: "Bitwarden_Authenticator_Mobile", | ||
| appVersion: Bundle.main.appVersion, | ||
| buildNumber: Bundle.main.buildNumber, | ||
| systemDevice: UIDevice.current | ||
| ) |
There was a problem hiding this comment.
♻️ I think we should refactor this at some point (perhaps when moving it to the Kit) to be able to test the values we're padding to the default headers request handler. Because right now if we change any of this all the tests will pass just fine. But we can definitely do it in another PR so it updates also the PM side one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/BWA-155
📔 Objective
To continue the process of moving the
ConfigServiceintoBitwardenKit, this brings slimmed-down versions ofAPIServiceandEnvironmentServiceintoAuthenticatorShared. These slimmed-down versions don't have a concept of an account, shortcutting bringing account-aware things such asTokenServiceintoBitwardenKit. Protocols, however, now live inBitwardenKit.At some point in the future more work can be done to unify these and bring them more firmly into
BitwardenKit, but that will probably require bringing a lot of account-related infrastructure intoBitwardenKit, which would imply that BWA would also become account-aware.⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes