[BWA-155] feat: Get new server config on BWA startup #1518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great job, no security vulnerabilities found in this Pull Request |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1518 +/- ##
===========================================
- Coverage 89.68% 70.16% -19.53%
===========================================
Files 776 257 -519
Lines 48899 11680 -37219
===========================================
- Hits 43855 8195 -35660
+ Misses 5044 3485 -1559 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vvolkgang
approved these changes
Apr 23, 2025
matt-livefront
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/BWA-155
📔 Objective
This enables remote feature flags in BWA by having it check the server for a new configuration on app startup.
While this is technically pre-Auth, PM likewise defaults to not marking this as pre-Auth, so I maintained that pattern. Given that BWA currently defaults to a user ID of "local", I don't think we need additional pre-Auth logic or flags here. And if/when we introduce actually logging in to the BWA, we'll need to re-do all of the logic around the
AppSettingsStoreand its user ID handling to begin with, and can better handle pre-Auth scenarios at that time.⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes