8000 ci: Update Xcode to 16.3 by KatherineInCode · Pull Request #1510 · bitwarden/ios · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

ci: Update Xcode to 16.3 #1510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 21, 2025
Merged

ci: Update Xcode to 16.3 #1510

merged 4 commits into from
Apr 21, 2025

Conversation

KatherineInCode
Copy link
Contributor

📔 Objective

This updates the version of Xcode used in CI to 16.3, and fixes failing tests as a result.

Because Xcode 16.3 fixes the AnyView issues introduced in 16.1, the changes made in #1070 have largely been reverted.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsf6b2400f-48a7-43d9-a980-0a19652e29f8

Great job, no security vulnerabilities found in this Pull Request

Copy link
codecov bot commented Apr 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.97%. Comparing base (da52a5f) to head (719a6c2).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1510      +/-   ##
==========================================
- Coverage   89.73%   85.97%   -3.76%     
==========================================
  Files         785      995     +210     
  Lines       49286    59458   +10172     
==========================================
+ Hits        44225    51119    +6894     
- Misses       5061     8339    +3278     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@KatherineInCode KatherineInCode marked this pull request as ready for review April 18, 2025 20:50
@KatherineInCode KatherineInCode requested review from a team and matt-livefront as code owners April 18, 2025 20:50
@KatherineInCode KatherineInCode merged commit ea7619e into main Apr 21, 2025
12 checks passed
@KatherineInCode KatherineInCode deleted the katherine/xcode-16-3 branch April 21, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0