8000 [PM-18414] CI restructuring #4 - Consolidate build.sh by vvolkgang · Pull Request #1526 · bitwarden/ios · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[PM-18414] CI restructuring #4 - Consolidate build.sh #1526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 24, 2025

Conversation

vvolkgang
Copy link
Member
@vvolkgang vvolkgang commented Apr 24, 2025

🎟️ Tracking

PM-18414

📔 Objective

Splitting this change from the bigger CI restructuring branch.

Consolidates Password Manager and Authenticator build.sh files and as a consequence we now have the building blocks to create Authenticator builds for Simulator - used for automated UI testing -, which'll be introduced in new workflows.

Test runs:

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@vvolkgang vvolkgang requested review from a team and matt-livefront as code owners April 24, 2025 13:53
Copy link
codecov bot commented Apr 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.95%. Comparing base (6b72644) to head (205972f).
Report is 56 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1526      +/-   ##
==========================================
- Coverage   89.68%   85.95%   -3.74%     
==========================================
  Files         777      988     +211     
  Lines       48965    59221   +10256     
==========================================
+ Hits        43916    50901    +6985     
- Misses       5049     8320    +3271     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor
github-actions bot commented Apr 24, 2025

Logo
Checkmarx One – Scan Summary & Detailsfc36150f-8352-48d1-bb73-db895c80e179

Great job, no security vulnerabilities found in this Pull Request

@vvolkgang vvolkgang enabled auto-merge (squash) April 24, 2025 14:53
@vvolkgang vvolkgang merged commit 48dd1b7 into main Apr 24, 2025
14 of 15 checks passed
@vvolkgang vvolkgang deleted the monorepo/consolidate-build branch April 24, 2025 17:09
@vvolkgang vvolkgang added the t:ci Updates to automated workflows label May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:ci Updates to automated workflows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0