8000 [PM-20429] Fix item icon color. by andrebispo5 · Pull Request #1553 · bitwarden/ios · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[PM-20429] Fix item icon color. #1553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2025
Merged

Conversation

andrebispo5
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-20429

📔 Objective

Fix bug where the icon color in the item view page was not being rendered correctly.

📸 Screenshots

Simulator Screenshot - iPhone 16 Pro - 2025-05-05 at 18 57 13
Simulator Screenshot - iPhone 16 Pro - 2025-05-05 at 18 56 48

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@andrebispo5 andrebispo5 requested review from matt-livefront and a team as code owners May 5, 2025 18:00
Copy link
Contributor
github-actions bot commented May 5, 2025

Logo
Checkmarx One – Scan Summary & Details5c05e4e6-734e-45e5-8c94-cf15a5cbcde8

Great job, no security vulnerabilities found in this Pull Request

Copy link
codecov bot commented May 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.72%. Comparing base (8ce8f80) to head (0196f8c).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #1553    +/-   ##
========================================
  Coverage   89.71%   89.72%            
========================================
  Files         780      781     +1     
  Lines       49311    49436   +125     
========================================
+ Hits        44241    44358   +117     
- Misses       5070     5078     +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andrebispo5 andrebispo5 merged commit e225432 into main May 6, 2025
10 checks passed
@andrebispo5 andrebispo5 deleted the pm-20429/item-icon-color-bug branch May 6, 2025 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0