[BWA-155] refactor: Bring ConfigService into BitwardenKit #1572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great job, no security vulnerabilities found in this Pull Request |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1572 +/- ##
==========================================
- Coverage 89.71% 85.99% -3.72%
==========================================
Files 786 993 +207
Lines 49533 59571 +10038
==========================================
+ Hits 44437 51230 +6793
- Misses 5096 8341 +3245 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fedemkr
reviewed
May 9, 2025
fedemkr
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/BWA-155
📔 Objective
This brings
ConfigServiceintoBItwardenKit, and therefore unifies how feature flags are handled between the two apps.In order to handle this, I broke out a
ConfigStateServiceandConfigSettingsStore, asStateServiceandAppSettingsStoreare very large objects/protocols that can't be brought in themselves. I went back and forth on moving the implementations of the new protocols into extensions, like we do with the biometrics-related ones, and ultimately decided not to for simplicity's sake, but it's not a strong opinion.I also tidied up a number of warnings left over from some of the previous groundwork-laying PRs.
This should put a neat bow on getting remote feature flags into BWA.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes