BIT-980: Update SDK password generator request to include minimum character set counts #184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…racter set counts
fedemkr
previously approved these changes
Dec 11, 2023
|
No New Or Fixed Issues Found |
BitwardenShared/UI/Tools/Generator/Generator/GeneratorStateTests.swift
Outdated
Show resolved
Hide resolved
Co-authored-by: Eliot Williams <148839008+eliot-livefront@users.noreply.github.com>
vvolkgang
pushed a commit
that referenced
this pull request
Feb 24, 2025
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
BIT-980
🚧 Type of change
📔 Objective
This updates the SDK password generator request to include the minimum counts for the different character sets (lowercase, uppercase, numbers and symbols). If the toggle for the character set is off,
nilis passed based on the docs here:https://github.com/bitwarden/sdk/blob/e6977ae187f0cfe90c5be4cc6a79a2375be2b1bb/crates/bitwarden/src/tool/generators/password.rs#L31-L42
📋 Code changes
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes