BIT-936: Add vault settings UI #209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No New Or Fixed Issues Found |
Bitwarden code coverageTotal coverage:
|
| File | Coverage |
|---|---|
| BitwardenShared/UI/Platform/Settings/Settings/SettingsProcessor.swift | 100.00% |
| BitwardenShared/UI/Platform/Settings/Settings/SettingsView.swift | 82.69% |
| BitwardenShared/UI/Platform/Settings/Settings/Vault/VaultSettingsProcessor.swift | 23.53% |
| BitwardenShared/UI/Platform/Settings/Settings/Vault/VaultSettingsView.swift | 100.00% |
| BitwardenShared/UI/Platform/Settings/SettingsCoordinator.swift | 100.00% |
Powered by Slather
Generated by 🚫 Danger
nathan-livefront
suggested changes
Dec 18, 2023
BitwardenShared/UI/Platform/Settings/Settings/Vault/VaultSettingsProcessor.swift
Outdated
Show resolved
Hide resolved
BitwardenShared/UI/Platform/Settings/Settings/Vault/VaultSettingsView.swift
Show resolved
Hide resolved
50e6ba6 to
d06ff17
Compare
d06ff17 to
333aaa2
Compare
nathan-livefront
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
BIT-936
🚧 Type of change
🚀 New feature development
📔 Objective
Added the UI for the first screen of the vault menu in the settings section.
📋 Code changes
Settings/Vault/*: Added the UI and the boilerplate for the Vault settings view in the settings section.
SettingsAction.swift: The action to get to the vault view
SettingsProcessor.swift: Navigate to the vault view
SettingsView.swift: Functionality for the vault button
SettingsCoordinator.swift: Navigate to the vault view
SettingsRoute.swift: Navigate to the vault view
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes