BIT-434: Add folders view #219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No New Or Fixed Issues Found |
Bitwarden code coverageTotal coverage:
|
| File | Coverage |
|---|---|
| BitwardenShared/Core/Platform/Repositories/SettingsRepository.swift | 100.00% |
| BitwardenShared/Core/Platform/Services/ServiceContainer.swift | 97.52% |
| BitwardenShared/Core/Vault/Services/FolderService.swift | 100.00% |
| BitwardenShared/UI/Platform/Application/Extensions/View.swift | 100.00% |
| BitwardenShared/UI/Platform/Settings/Settings/Vault/Folders/FoldersProcessor.swift | 67.74% |
| BitwardenShared/UI/Platform/Settings/Settings/Vault/Folders/FoldersState.swift | 100.00% |
| BitwardenShared/UI/Platform/Settings/Settings/Vault/Folders/FoldersView.swift | 100.00% |
| BitwardenShared/UI/Platform/Settings/Settings/Vault/VaultSettingsProcessor.swift | 75.00% |
| BitwardenShared/UI/Platform/Settings/SettingsCoordinator.swift | 100.00% |
Powered by Slather
Generated by 🚫 Danger
nathan-livefront
approved these changes
Dec 19, 2023
fedemkr
reviewed
Dec 21, 2023
| state.folders = value | ||
| } | ||
| } catch { | ||
| services.errorReporter.log(error: error) |
There was a problem hiding this comment.
🤔 @shannon-livefront in case an error happens here, shouldn't we let the user know that an error happen and that's why they are not seeing any folders? If not they might think that the folders aren't loading and wait there for a while.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BIT-434
🚧 Type of change
🚀 New feature development
📔 Objective
Added UI and functionality to view the current list of the user's folders.
📋 Code changes
FolderView+Fixtures.swift: Fixtures for FolderView and Folder for use in testing
SettingsRepository.swift: Added a publisher for the flow of user's folders
FolderService.swift: Added a publisher for the flow of user's folders
View.swift: Added a shortcut for an "add" toolbar button
Settings/Vault/Folders/*: Added all the UI and boilerplate for showing the list of folders
SettingsCoordinator.swift: Added navigation to the folders view
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes