BIT-766: Fixes a bug with the textfield clear button visibility #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bitwarden code coverageTotal coverage:
|
| File | Coverage |
|---|---|
| BitwardenShared/UI/Platform/Application/Views/BitwardenTextField.swift | 57.43% |
Powered by Slather
Generated by 🚫 Danger
|
No New Or Fixed Issues Found |
There was a problem hiding this comment.
This looks good, but I think @shannon-livefront's snapshots from the add folder PR will need to be updated.
matt-livefront
approved these changes
Dec 20, 2023
matt-livefront
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
BIT-766
🚧 Type of change
📔 Objective
This PR fixes a small issue with the clear button in textfields throughout the app. Previously, the clear button would show whenever there was text in the field. Now, the clear button will only be visible when there is text in the field and the field is currently focused.
📋 Code changes
📸 Screenshots
RocketSim_Recording_iPhone_15_Pro_6.1_2023-12-14_20.07.25.mp4
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes