8000 BIT-936: Remove divider on vault menu by shannon-livefront · Pull Request #228 · bitwarden/ios · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

BIT-936: Remove divider on vault menu #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy 8000 statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 21, 2023

Conversation

shannon-livefront
Copy link
Collaborator

🎟️ Tracking

BIT-936

🚧 Type of change

  • 🐛 Bug fix

📔 Objective

Remove the divider after the final item in the list of vault settings. Also added a few missing snapshots while I was at it.

📋 Code changes

  • VaultSettingsView.swift: Removed the divider of the final item of the settings list and added a missing preview
  • VaultSettingsViewTests.swift: Added missing snapshots

📸 Screenshots

Before After

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor
@nathan-livefront nathan-livefront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

Copy link
Contributor
1 Warning
⚠️ Ignoring duplicate libraries: '-lbitwarden_uniffi'

Bitwarden code coverage

Total coverage: 86.00%

File Coverage
BitwardenShared/UI/Platform/Settings/Settings/Vault/VaultSettingsView.swift 100.00%

Powered by Slather

Generated by 🚫 Danger

@bitwarden-bot
Copy link

Logo
Checkmarx One – Scan Summary & Details5f414d36-add8-447f-8593-9247053d7a2d

No New Or Fixed Issues Found

@shannon-livefront shannon-livefront merged commit 8973f2b into main Dec 21, 2023
@shannon-livefront shannon-livefront deleted the shannon/BIT-936-remove-divider-on-vault-menu branch December 21, 2023 16:36
vvolkgang pushed a commit that referenced this pull request Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0