BIT-348, BIT-351, & BIT-1121: Add, Save, View, & Edit Card Type Cipher #229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # BitwardenShared/UI/Vault/VaultItem/AddEditItem/__Snapshots__/AddEditItemViewTests/test_snapshot_edit_full_fieldsNotVisible_largeText.1.png # BitwardenShared/UI/Vault/VaultItem/AddEditItem/__Snapshots__/AddEditItemViewTests/test_snapshot_edit_full_fieldsVisible_largeText.1.png # BitwardenShared/UI/Vault/VaultItem/AddEditItem/__Snapshots__/AddEditItemViewTests/test_snapshot_previews_addEditItemView.4.png # BitwardenShared/UI/Vault/VaultItem/AddEditItem/__Snapshots__/AddEditItemViewTests/test_snapshot_previews_addEditItemView.5.png # BitwardenShared/UI/Vault/VaultItem/AddEditItem/__Snapshots__/AddEditItemViewTests/test_snapshot_previews_addEditItemView.6.png # BitwardenShared/UI/Vault/VaultItem/AddEditItem/__Snapshots__/AddEditItemViewTests/test_snapshot_previews_addEditItemView.7.png # BitwardenShared/UI/Vault/VaultItem/AddEditItem/__Snapshots__/AddEditItemViewTests/test_snapshot_previews_addEditItemView.8.png # BitwardenShared/UI/Vault/VaultItem/AddEditItem/__Snapshots__/AddEditItemViewTests/test_snapshot_previews_addEditItemView.9.png # BitwardenShared/UI/Vault/VaultItem/AddEditItem/__Snapshots__/AddEditLoginItemViewTests/test_snapshot_addEditLoginItemView.6.png # BitwardenShared/UI/Vault/VaultItem/ViewItem/ViewItemProcessor.swift
|
No New Or Fixed Issues Found |
Bitwarden code coverageTotal coverage:
|
| File | Coverage |
|---|---|
| BitwardenShared/UI/Vault/VaultItem/AddEditItem/AddEditCardItem/AddEditCardItemView.swift | 100.00% |
| BitwardenShared/UI/Vault/VaultItem/AddEditItem/AddEditCardItem/CardComponent.swift | 77.08% |
| BitwardenShared/UI/Vault/VaultItem/AddEditItem/AddEditCardItem/CardItemState.swift | 100.00% |
| BitwardenShared/UI/Vault/VaultItem/AddEditItem/AddEditItemProcessor.swift | 92.49% |
| BitwardenShared/UI/Vault/VaultItem/AddEditItem/AddEditItemView.swift | 99.17% |
| BitwardenShared/UI/Vault/VaultItem/CipherItemState.swift | 98.47% |
| BitwardenShared/UI/Vault/VaultItem/ViewItem/ViewCardItem/ViewCardItemView.swift | 91.72% |
| BitwardenShared/UI/Vault/VaultItem/ViewItem/ViewItemAction.swift | 78.57% |
| BitwardenShared/UI/Vault/VaultItem/ViewItem/ViewItemDetailsView.swift | 94.48% |
| BitwardenShared/UI/Vault/VaultItem/ViewItem/ViewItemProcessor.swift | 90.32% |
| BitwardenShared/UI/Vault/VaultItem/ViewItem/ViewItemView.swift | 84.51% |
| BitwardenShared/UI/Vault/VaultItem/ViewItem/ViewLoginItem/Extensions/CipherView+Update.swift | 98.96% |
Powered by Slather
Generated by 🚫 Danger
BitwardenShared/UI/Vault/VaultItem/AddEditItem/AddEditCardItem/AddEditCardItemView.swift
Show resolved
Hide resolved
Comment on lines
237
to
241
| matching: ViewItemView_Previews.cardPreview, | ||
| as: [ | ||
| .tallPortrait, | ||
| .defaultPortraitDark, | ||
| .tallPortraitAX5(heightMultiple: 2), |
There was a problem hiding this comment.
🤔 I think one of the downsides of snapshotting the previews is that you lose out on having the ability to include context of what the snapshot contains in the generated file. Any idea if we can get the preview display name to use that + the configuration in the filename?
Having that context is nice IMO if you look back at these in Xcode or if one is failing:
There was a problem hiding this comment.
I split them all out.
|
|
||
| /// A protocol for a sendable type that models a Card Item in it's add/edit state. | ||
| /// | ||
| protocol AddEditCardItemState: Equatable, Sendable { |
There was a problem hiding this comment.
🤔 I'm curious the benefit we get from having this protocol and ViewCardItemState over using CardItemState directly?
There was a problem hiding this comment.
My goal was to build in some separation from the State to the ViewState and remove the ability to mutate the struct in a view configuration. I build this pattern to match the one used for CipherItemState, AddEditItemState, and ViewVaultItemState
# Conflicts: # BitwardenShared/Core/Vault/Extensions/TestHelpers/BitwardenSdk+VaultFixtures.swift # BitwardenShared/UI/Vault/VaultItem/AddEditItem/AddEditItemAction.swift # BitwardenShared/UI/Vault/VaultItem/AddEditItem/AddEditItemProcessor.swift # BitwardenShared/UI/Vault/VaultItem/AddEditItem/__Snapshots__/AddEditItemViewTests/test_snapshot_edit_full_fieldsNotVisible_largeText.1.png # BitwardenShared/UI/Vault/VaultItem/AddEditItem/__Snapshots__/AddEditItemViewTests/test_snapshot_edit_full_fieldsVisible_largeText.1.png # BitwardenShared/UI/Vault/VaultItem/AddEditItem/__Snapshots__/AddEditItemViewTests/test_snapshot_previews_addEditItemView.2.png # BitwardenShared/UI/Vault/VaultItem/AddEditItem/__Snapshots__/AddEditItemViewTests/test_snapshot_previews_addEditItemView.4.png # BitwardenShared/UI/Vault/VaultItem/AddEditItem/__Snapshots__/AddEditItemViewTests/test_snapshot_previews_addEditItemView.5.png # BitwardenShared/UI/Vault/VaultItem/AddEditItem/__Snapshots__/AddEditItemViewTests/test_snapshot_previews_addEditItemView.7.png # BitwardenShared/UI/Vault/VaultItem/AddEditItem/__Snapshots__/AddEditItemViewTests/test_snapshot_previews_addEditItemView.8.png # BitwardenShared/UI/Vault/VaultItem/CipherItemState.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
BIT-348
BIT-351
BIT-1121
🚧 Type of change
📔 Objective
Create, Read, & Update Card type Ciphers.
📋 Code changes
📸 Screenshots
card-cipher.mp4
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes