8000 BIT-749: Vault export view by shannon-livefront · Pull Request #230 · bitwarden/ios · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

BIT-749: Vault export view #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 21, 2023
Merged

Conversation

shannon-livefront
Copy link
Collaborator

🎟️ Tracking

BIT-749

🚧 Type of change

  • 🚀 New feature development

📔 Objective

Adds the UI for the export vault view.

📋 Code changes

  • SettingsCoordinator.swift: Navigate to the export vault view
  • SettingsRoute.swift: The route to navigate to the export vault view
  • VaultSettingsProcessor.swift: The button to navigate to the export vault view
  • Settings/Vault/ExportVault/*: The export vault view

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

8000
Copy link
Contributor
1 Warning
⚠️ Ignoring duplicate libraries: '-lbitwarden_uniffi'

Bitwarden code coverage

Total coverage: 86.00%

File Coverage
BitwardenShared/Core/Platform/Models/Enum/ExportFormatType.swift 100.00%
BitwardenShared/UI/Platform/Settings/Settings/Vault/ExportVault/ExportVaultProcessor.swift 94.44%
BitwardenShared/UI/Platform/Settings/Settings/Vault/ExportVault/ExportVaultState.swift 100.00%
BitwardenShared/UI/Platform/Settings/Settings/Vault/ExportVault/ExportVaultView.swift 98.04%
BitwardenShared/UI/Platform/Settings/Settings/Vault/VaultSettingsProcessor.swift 86.67%
BitwardenShared/UI/Platform/Settings/SettingsCoordinator.swift 100.00%

Powered by Slather

Generated by 🚫 Danger

@bitwarden-bot
Copy link
bitwarden-bot commented Dec 21, 2023

Logo
Checkmarx One – Scan Summary & Details4694377d-f834-4c2f-99ed-863c4bb364e1

No New Or Fixed Issues Found

Copy link
Contributor
@nathan-livefront nathan-livefront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! I left a few minor suggestions

shannon-livefront and others added 2 commits December 21, 2023 14:22
…t/ExportVaultView.swift

Co-authored-by: Nathan Ansel <nathan@livefront.com>
…t/ExportVaultView.swift

Co-authored-by: Nathan Ansel <nathan@livefront.com>
Copy link
Contributor
@nathan-livefront nathan-livefront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@shannon-livefront shannon-livefront merged commit dd77664 into main Dec 21, 2023
@shannon-livefront shannon-livefront deleted the shannon/BIT-749-vault-export-view branch December 21, 2023 21:26
vvolkgang pushed a commit that referenced this pull request Feb 24, 2025
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0