-
Notifications
You must be signed in to change notification settings - Fork 53
BIT-749: Vault export view #230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Bitwarden code coverageTotal coverage:
|
File | Coverage |
---|---|
BitwardenShared/Core/Platform/Models/Enum/ExportFormatType.swift | 100.00% |
BitwardenShared/UI/Platform/Settings/Settings/Vault/ExportVault/ExportVaultProcessor.swift | 94.44% |
BitwardenShared/UI/Platform/Settings/Settings/Vault/ExportVault/ExportVaultState.swift | 100.00% |
BitwardenShared/UI/Platform/Settings/Settings/Vault/ExportVault/ExportVaultView.swift | 98.04% |
BitwardenShared/UI/Platform/Settings/Settings/Vault/VaultSettingsProcessor.swift | 86.67% |
BitwardenShared/UI/Platform/Settings/SettingsCoordinator.swift | 100.00% |
Powered by Slather
Generated by 🚫 Danger
No New Or Fixed Issues Found |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great! I left a few minor suggestions
BitwardenShared/UI/Platform/Settings/Settings/Vault/ExportVault/ExportVaultView.swift
Outdated
Show resolved
Hide resolved
BitwardenShared/UI/Platform/Settings/Settings/Vault/ExportVault/ExportVaultView.swift
Outdated
Show resolved
Hide resolved
…t/ExportVaultView.swift Co-authored-by: Nathan Ansel <nathan@livefront.com>
…t/ExportVaultView.swift Co-authored-by: Nathan Ansel <nathan@livefront.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
🎟️ Tracking
BIT-749
🚧 Type of change
📔 Objective
Adds the UI for the export vault view.
📋 Code changes
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes