8000 BIT-161: Import existing localizations by matt-livefront · Pull Request #27 · bitwarden/ios · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

BIT-161: Import existing localizations #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 12, 2023

Conversation

matt-livefront
Copy link
Collaborator

🎟️ Tracking

BIT-161

🚧 Type of change

  • 🎂 Other

📔 Objective

Imports the existing localizations from the Xamarin app so we can reuse the translations.

📋 Code changes

  • Localizable.strings: The existing string files containing localizations.
  • swiftgen.yml: Sets up Swiftgen to generate static variables for the localization keys.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@bitwarden-bot
Copy link
bitwarden-bot commented Sep 12, 2023

Logo
Checkmarx One – Scan Summary & Detailsa3318026-82ad-43db-93e6-6d0aea0e69a5

No New Or Fixed Issues Found

Copy link
Contributor
@nathan-livefront nathan-livefront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding these localizations!

@github-actions
Copy link
Contributor
1 Warning
⚠️ Total coverage less than 80%

Code coverage

Total coverage: 47.87%

Powered by Slather

Generated by 🚫 Danger

fedemkr
fedemkr previously approved these changes Sep 12, 2023
@matt-livefront matt-livefront merged commit 888dfd6 into main Sep 12, 2023
@matt-livefront matt-livefront deleted the matt/BIT-161-localizations branch September 12, 2023 18:36
vvolkgang pushed a commit that referenced this pull request Feb 24, 2025
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0