feat(innovation-archive): [PM-19151] Controller Work #5496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8000
…the ArchivedDate column
…controller-updates
…archive and feature flagged them.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## innovation/archive/server #5496 +/- ##
============================================================
Coverage ? 47.70%
============================================================
Files ? 1545
Lines ? 70935
Branches ? 6347
============================================================
Hits ? 33839
Misses ? 35684
Partials ? 1412 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
New Issues (116)Checkmarx found the following issues in this Pull Request
|
…ete implementation.
c75ec56 to
bed5e20
Compare
|
Found some bugs, resolving them now. |
9E19
r-tome
reviewed
Mar 20, 2025
<
F438
/div>
|
Thank you for the comments regarding documentation @r-tome, it is on my checklist as the code nears it's ready state. |
…g back on all responses now.
|
It would be appreciated for everyone to mark all their threads resolved that have been addressed. Helps it make the PR look a little less chaotic and easier to see what is outstanding work. |
util/Migrator/DbScripts/2025-03-11_01_Archive_Unarchive_Procedures.sql
Outdated
Show resolved
Hide resolved
shane-melton
requested changes
Mar 20, 2025
util/Migrator/DbScripts/2025-03-20_00_Archive_Unarchive_Procedures.sql
Outdated
Show resolved
Hide resolved
gbubemismith
approved these changes
Mar 20, 2025
r-tome
approved these changes
Mar 24, 2025
|
5cbf4c5
into
innovation/archive/server
31 of 32 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📔 Objective
Archive and Unarchive Implementation
Duplicated all soft delete functions and renamed / repurposed the functionality relatively to fit the Archive feature.
new endpoints:
Archive -
/api/ciphers/<cipher_id>/archiveBulk Archive -
/api/ciphers/archiveUnarchive -
/api/ciphers/<cipher_id>/unarchiveBulk Unarchive -
/api/ciphers/unarchive📸 Screenshots
Screen.Recording.2025-03-13.at.10.58.04.AM.mov
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes