8000 [PM- 19438] emergency access docs by ike-kottlowski · Pull Request #5846 · bitwarden/server · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[PM- 19438] emergency access docs #5846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 28, 2025
Merged

[PM- 19438] emergency access docs #5846

merged 6 commits into from
May 28, 2025

Conversation

ike-kottlowski
Copy link
Contributor
@ike-kottlowski ike-kottlowski commented May 20, 2025 •
edited by jira bot
Loading

🎟️ Tracking

PM-19438

📔 Objective

Improve team understanding and documentation Surrounding the emergency access user feature.

There are no functional changes that need to be tested.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@ike-kottlowski ike-kottlowski requested a review from a team as a code owner May 20, 2025 21:10
@ike-kottlowski ike-kottlowski requested a review from rr-bw May 20, 2025 21:10
@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented May 20, 2025 •
edited
Loading

Logo
Checkmarx One – Scan Summary & Details – c931e975-7c43-463d-b794-44f1d0aca27d

New Issues (1)

Checkmarx found the following issues in this Pull Request

Severity Issue Source File / Package Checkmarx Insight
MEDIUM CSRF /src/Billing/Controllers/PayPalController.cs: 70
detailsMethod PostIpn at line 70 of /src/Billing/Controllers/PayPalController.cs gets a parameter from a user request from Body. This parameter value fl...
ID: HIRv8XJ2uwImOjFqQXDx3QjwhSo%3D
Attack Vector
Fixed Issues (1)

Great job! The following issues were fixed in this Pull Request

Severity Issue Source File / Package
MEDIUM CSRF /src/Billing/Controllers/FreshdeskController.cs: 43

@rr-bw rr-bw requested review from JaredSnider-Bitwarden and removed request for rr-bw May 21, 2025 19:52
@codecov Codecov
Copy link
codecov bot commented May 22, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 91.42857% with 3 lines in your changes missing coverage. Please review.

Project coverage is 47.51%. Comparing base (fbc8e06) to head (404616d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...Services/EmergencyAccess/EmergencyAccessService.cs 91.42% 0 Missing and 3 partials ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5846   +/-   ##
=======================================
  Coverage   47.51%   47.51%           
=======================================
  Files        1662     1662           
  Lines       75215    75215           
  Branches     6761     6761           
=======================================
  Hits        35737    35737           
  Misses      38015    38015           
  Partials     1463     1463

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

JaredSnider-Bitwarden
JaredSnider-Bitwarden requested changes May 27, 2025
View reviewed changes
Copy link
Contributor
@JaredSnider-Bitwarden JaredSnider-Bitwarden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Just a few tiny nits and a question.

@sonarqubecloud SonarQubeCloud
8000 Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

JaredSnider-Bitwarden
JaredSnider-Bitwarden approved these changes May 28, 2025
View reviewed changes
Copy link
Contributor
@JaredSnider-Bitwarden JaredSnider-Bitwarden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work!

@ike-kottlowski ike-kottlowski merged commit 4f326da into main May 28, 2025
53 checks passed
@ike-kottlowski ike-kottlowski deleted the auth/pm-19438/emergency-access-docs branch May 28, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaredSnider-Bitwarden JaredSnider-Bitwarden JaredSnider-Bitwarden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ike-kottlowski @JaredSnider-Bitwarden
0