8000 [PM-19127] - Nested Traverse Optimization Feature Flag by jrmccannon · Pull Request #5853 · bitwarden/server · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[PM-19127] - Nested Traverse Optimization Feature Flag #5853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send yo 8000 u account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2025

Conversation

jrmccannon
Copy link
Contributor
@jrmccannon jrmccannon commented May 22, 2025

🎟️ Tracking

PM-19127

📔 Objective

Adding feature flag for the nested traverse optimization

Client PR

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details64dfe071-fb0e-4f65-b4d8-703a4edba5ff

Great job, no security vulnerabilities found in this Pull Request

Copy link
codecov bot commented May 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.54%. Comparing base (18d1464) to head (dc6f890).
Report is 31 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5853      +/-   ##
==========================================
- Coverage   50.72%   47.54%   -3.19%     
==========================================
  Files        1651     1651              
  Lines       74810    74814       +4     
  Branches     6723     6724       +1     
==========================================
- Hits        37951    35569    -2382     
- Misses      35340    37787    +2447     
+ Partials     1519     1458      -61     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jrmccannon jrmccannon requested a review from BTreston May 29, 2025 14:35
@jrmccannon jrmccannon merged commit d50ad97 into main May 29, 2025
53 checks passed
@jrmccannon jrmccannon deleted the jmccannon/ac/pm-19127-nested-traverse-flag branch May 29, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0