8000 [PM-21561] List all MSP service users by BTreston · Pull Request #5888 · bitwarden/server · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[PM-21561] List all MSP service users #5888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2025

Conversation

BTreston
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-21561

📔 Objective

Modifies the admin portal to show admin and service users, changes verbiage for the table title.

📸 Screenshots

Screenshot 2025-05-28 at 10 23 12 AM

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@BTreston BTreston requested a review from a team as a code owner May 28, 2025 14:30
@BTreston BTreston requested a review from r-tome May 28, 2025 14:30
Copy link

Copy link
codecov bot commented May 28, 2025

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 47.50%. Comparing base (fbc8e06) to head (b8ee667).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...c/Admin/AdminConsole/Views/Providers/Admins.cshtml 0.00% 9 Missing ⚠️
src/Admin/AdminConsole/Models/ProviderViewModel.cs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5888      +/-   ##
==========================================
- Coverage   47.51%   47.50%   -0.01%     
==========================================
  Files        1662     1662              
  Lines       75215    75220       +5     
  Branches     6761     6762       +1     
==========================================
  Hits        35737    35737              
- Misses      38015    38020       +5     
  Partials     1463     1463              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsf49aefcc-25bf-4bde-9caf-c7878cb1467e

Great job, no security vulnerabilities found in this Pull Request

@BTreston BTreston merged commit cd994f7 into main May 28, 2025
53 checks passed
@BTreston BTreston deleted the ac/pm-21561-add-column-to-provider-portal branch May 28, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0