Refactor PendingSecurityTasks to RefreshSecurityTasks
#5903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allows for more general use case of security task notifications
This was referenced Jun 2, 2025
|
|
New Issues (2)Checkmarx found the following issues in this Pull Request
Fixed Issues (1)Great job! The following issues were fixed in this Pull Request
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## vault/pm-20041/mark-task-complete #5903 +/- ##
=====================================================================
- Coverage 50.80% 47.50% -3.30%
=====================================================================
Files 1670 1670
Lines 75417 75417
Branches 6766 6766
=====================================================================
- Hits 38316 35830 -2486
- Misses 35582 38128 +2546
+ Partials 1519 1459 -60 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on top of #5896, I'll leave this as a draft to rebase once that merges.
🎟️ Tracking
N/A
📔 Objective
Client PR: bitwarden/clients#15021
As a part of #5896, I utilized the
PendingSecurityTaskspush type to trigger a refresh of the security tasks on the clients. This is currently on the clients are utilizing the notification but now the namePendingSecurityTasksdoesn't match the all of the use cases.PendingSecurityTaskstoRefreshSecurityTasksto align for more general use cases of security task notifications.🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes