[PM-19703] Fix admin count logic to exclude current organization #5918
+126
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[PM-19703] Fix admin count logic to exclude current organization
|
Great job, no security vulnerabilities found in this Pull Request |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5918 +/- ##
==========================================
- Coverage 47.62% 47.62% -0.01%
==========================================
Files 1665 1665
Lines 75101 75117 +16
Branches 6768 6772 +4
==========================================
+ Hits 35768 35775 +7
- Misses 37878 37884 +6
- Partials 1455 1458 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
r-tome
approved these changes
Jun 5, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-19703
📔 Objective
This change fixes an edge case in the edit user flow where the admin count check incorrectly included the current organization. As a result, attempts to modify a user who is already an admin or owner of the current org were mistakenly blocked.
Code changes
UpdateUserAsyncand its new parameter,existingUserType.📸 Screenshots
Performed manual testing for sanity check.
Testing.the.user.edit.flow.mov
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes