10000 PM-22564 Fix Namespaces from Tools to Dirt by prograhamming · Pull Request #5947 · bitwarden/server · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

PM-22564 Fix Namespaces from Tools to Dirt #5947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 10, 2025
Merged

PM-22564 Fix Namespaces from Tools to Dirt #5947

merged 3 commits into from
Jun 10, 2025

Conversation

prograhamming
Copy link
Contributor
@prograhamming prograhamming commented Jun 10, 2025 •
edited by jira bot
Loading

🎟️ Tracking

PM-22564

📔 Objective

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@prograhamming prograhamming requested review from a team as code owners June 10, 2025 15:24
audreyality
audreyality previously approved these changes Jun 10, 2025
View reviewed changes
Copy link
Member
@audreyality audreyality left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⛏️ Some of the namespaces are a bit long.

👍🏻 Matching the namespaces to the folders is a solid improvement.

Banrion
Banrion previously approved these changes Jun 10, 2025
View reviewed changes
@codecov Codecov
Copy link
codecov bot commented Jun 10, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 50.96%. Comparing base (021e69b) to head (87a26d8).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../Dirt/PasswordHealthReportApplicationRepository.cs 0.00% 1 Missing ⚠️
...ories/PasswordHealthReportApplicationRepository.cs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5947      +/-   ##
==========================================
+ Coverage   47.65%   50.96%   +3.31%     
==========================================
  Files        1665     1665              
  Lines       75099    75099              
  Branches     6765     6765              
==========================================
+ Hits        35786    38272    +2486     
+ Misses      37858    35312    -2546     
- Partials     1455     1515      +60

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Jun 10, 2025 •
edited
Loading

Logo
Checkmarx One – Scan Summary & Details – 6124aaf7-429b-4166-aada-92283a7c100e

Great job, no security vulnerabilities found in this Pull Request

@prograhamming prograhamming dismissed stale reviews from Banrion and audreyality via a319564 June 10, 2025 17:06
rkac-bw
rkac-bw approved these changes Jun 10, 2025
View reviewed changes
Copy link
Contributor
@rkac-bw rkac-bw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@prograhamming prograhamming merged commit 4277f43 into main Jun 10, 2025
41 checks passed
@prograhamming prograhamming deleted the dirt/pm-22564/update-namespaces-in-dirt branch June 10, 2025 17:36
mandreko-bitwarden pushed a commit that referenced this pull request Jun 13, 2025
@prograhamming @mandreko-bitwarden
PM-22564 Fix Namespaces from Tools to Dirt (#5947)
08a172c 
* PM-22564 fixing namespaces

* PM-22564 fixing namespace in integration test

* PM-22564 fixing .sqlproj file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@audreyality audreyality audreyality approved these changes

@Banrion Banrion Banrion approved these changes

@ttalty ttalty ttalty approved these changes

@rkac-bw rkac-bw rkac-bw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@prograhamming @audreyality @Banrion @ttalty @rkac-bw
0