8000 [PM-22572] Add app-intents feature flag key by fedemkr · Pull Request #5948 · bitwarden/server · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[PM-22572] Add app-intents feature flag key #5948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025

Conversation

fedemkr
Copy link
Member
@fedemkr fedemkr commented Jun 10, 2025

🎟️ Tracking

PM-22572

📔 Objective

Add app-intents feature flag key

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@fedemkr fedemkr changed the title [PM-22572] Added app-intents feature flag key [PM-22572] Add app-intents feature flag key Jun 10, 2025
@fedemkr fedemkr requested a review from differsthecat June 10, 2025 20:11
Copy link

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details189aa480-9f3b-4e74-873e-70d4d13e2f2e

Great job, no security vulnerabilities found in this Pull Request

Copy link
codecov bot commented Jun 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.65%. Comparing base (1bd11e6) to head (8742e60).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5948   +/-   ##
=======================================
  Coverage   47.65%   47.65%           
=======================================
  Files        1665     1665           
  Lines       75099    75099           
  Branches     6765     6765           
=======================================
  Hits        35786    35786           
  Misses      37858    37858           
  Partials     1455     1455           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fedemkr fedemkr merged commit f532236 into main Jun 10, 2025
39 checks passed
@fedemkr fedemkr deleted the add-app-intents-feature-flag branch June 10, 2025 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0