8000 [PM-22423] Add MJML by Hinton · Pull Request #5941 · bitwarden/server · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[PM-22423] Add MJML #5941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[PM-22423] Add MJML #5941

wants to merge 2 commits into from

Conversation

Hinton
Copy link
Member
@Hinton Hinton commented Jun 9, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-22423

📔 Objective

Scaffolds MJML and adds some initial templates and components.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@Hinton Hinton changed the title Add MJML [PM-22423] Add MJML Jun 9, 2025
@sonarqubecloud SonarQubeCloud
Copy link
sonarqubecloud bot commented Jun 9, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Jun 9, 2025 •
edited
Loading

Logo
Checkmarx One – Scan Summary & Details – bd74ad4d-89da-480e-9ca7-a46c3a026289

New Issues (2)

Checkmarx found the following issues in this Pull Request

Severity Issue Source File / Package Checkmarx Insight
CRITICAL Stored_XSS /src/SharedWeb/Health/HealthCheckServiceExtensions.cs: 58
detailsThe method WriteResponse embeds untrusted data in generated output with WriteAsync, at line 57 of /src/SharedWeb/Health/HealthCheckServiceExtension...
ID: vbK3CbsHTSkBsQ16ETn4voEuwCI%3D
Attack Vector
HIGH CVE-2022-37620 Npm-html-minifier-4.0.0
detailsDescription: A Regular Expression Denial of Service (ReDoS) flaw was found in html-minifier versions 2.1.0 through 4.0.0 via the "candidate" variable in "htmlmi...
Attack Vector: NETWORK
Attack Complexity: LOW

ID: 81ciuonlFW96LJO%2BqVHctNwp8ikBCX2b%2FBCKvQfNwNE%3D
Vulnerable Package
Fixed Issues (104)

Great job! The following issues were fixed in this Pull Request

Severity Issue Source File / Package
MEDIUM CSRF /src/Api/Controllers/SelfHosted/SelfHostedOrganizationSponsorshipsController.cs: 109
MEDIUM CSRF /src/Api/Billing/Controllers/OrganizationSponsorshipsController.cs: 274
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationIntegrationConfigurationController.cs: 22
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationIntegrationConfigurationController.cs: 81
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationIntegrationController.cs: 54
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationIntegrationController.cs: 23
MEDIUM CSRF /src/Api/AdminConsole/Controllers/SlackIntegrationController.cs: 47
MEDIUM CSRF /src/Admin/Billing/Controllers/BusinessUnitConversionController.cs: 68
MEDIUM CSRF /src/Api/Controllers/PhishingDomainsController.cs: 24
MEDIUM CSRF /src/Api/Controllers/PhishingDomainsController.cs: 12
MEDIUM CSRF /src/Api/Billing/Controllers/AccountsController.cs: 140
MEDIUM CSRF /src/Api/KeyManagement/Controllers/AccountsKeyManagementController.cs: 97
MEDIUM CSRF /src/Api/Controllers/DevicesController.cs: 75
MEDIUM CSRF /src/Api/Platform/Push/Controllers/PushController.cs: 52
MEDIUM CSRF /src/Api/AdminConsole/Controllers/PoliciesController.cs: 69
MEDIUM CSRF /src/Api/KeyManagement/Controllers/AccountsKeyManagementController.cs: 81
MEDIUM CSRF /src/Api/SecretsManager/Controllers/CountsController.cs: 37
MEDIUM CSRF /src/Api/SecretsManager/Controllers/SecretsController.cs: 86
MEDIUM CSRF /src/Api/AdminConsole/Public/Controllers/MembersController.cs: 95
MEDIUM CSRF /src/Api/AdminConsole/Controllers/ProvidersController.cs: 121
MEDIUM CSRF /src/Api/SecretsManager/Controllers/AccessPoliciesController.cs: 232
MEDIUM CSRF /src/Api/Vault/Controllers/FoldersController.cs: 45
MEDIUM CSRF /src/Api/Controllers/UsersController.cs: 22
MEDIUM CSRF /src/Api/AdminConsole/Public/Controllers/GroupsController.cs: 92
MEDIUM CSRF /src/Api/AdminConsole/Public/Controllers/GroupsController.cs: 49
MEDIUM CSRF /src/Api/AdminConsole/Controllers/GroupsController.cs: 80
MEDIUM CSRF /src/Api/Tools/Controllers/ImportCiphersController.cs: 47
MEDIUM CSRF /src/Api/Tools/Controllers/ImportCiphersController.cs: 63
MEDIUM CSRF /src/Api/Controllers/DevicesController.cs: 62
MEDIUM CSRF /src/Api/AdminConsole/Public/Controllers/PoliciesController.cs: 46
MEDIUM CSRF /src/Api/AdminConsole/Public/Controllers/PoliciesController.cs: 65
MEDIUM CSRF /src/Api/AdminConsole/Controllers/ProviderOrganizationsController.cs: 48
MEDIUM CSRF /src/Api/AdminConsole/Controllers/PoliciesController.cs: 90
MEDIUM CSRF /src/Api/AdminConsole/Controllers/GroupsController.cs: 121
MEDIUM CSRF /src/Admin/AdminConsole/Controllers/ProviderOrganizationsController.cs: 35
MEDIUM CSRF /src/Api/Auth/Controllers/WebAuthnController.cs: 107
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationDomainController.cs: 75
MEDIUM CSRF /src/Api/AdminConsole/Controllers/GroupsController.cs: 164
MEDIUM CSRF /src/Api/AdminConsole/Controllers/GroupsController.cs: 135
MEDIUM CSRF /src/Api/Auth/Controllers/WebAuthnController.cs: 175
MEDIUM CSRF /src/Api/Auth/Controllers/WebAuthnController.cs: 65
MEDIUM CSRF /src/Api/SecretsManager/Controllers/SecretsManagerPortingController.cs: 38
MEDIUM CSRF /src/Api/SecretsManager/Controllers/ProjectsController.cs: 140
MEDIUM CSRF /src/Api/Controllers/SelfHosted/SelfHostedOrganizationSponsorshipsController.cs: 80
MEDIUM CSRF /src/Api/SecretsManager/Controllers/SecretsManagerPortingController.cs: 58
MEDIUM CSRF /src/Api/Controllers/SelfHosted/SelfHostedOrganizationLicensesController.cs: 72
MEDIUM CSRF /src/Api/Billing/Controllers/OrganizationSponsorshipsController.cs: 78
MEDIUM CSRF /src/Api/Billing/Controllers/OrganizationSponsorshipsController.cs: 210
MEDIUM CSRF /src/Api/SecretsManager/Controllers/ServiceAccountsController.cs: 162
MEDIUM CSRF /src/Api/Auth/Controllers/AuthRequestsController.cs: 37
MEDIUM CSRF /src/Events/Controllers/CollectController.cs: 41
MEDIUM CSRF /src/Api/SecretsManager/Controllers/ServiceAccountsController.cs: 114
MEDIUM CSRF /src/Api/Dirt/Controllers/HibpController.cs: 43
MEDIUM CSRF /src/Api/Tools/Controllers/SendsController.cs: 201
MEDIUM CSRF /src/Api/AdminConsole/Public/Controllers/GroupsController.cs: 110
MEDIUM CSRF /src/Api/Tools/Controllers/SendsController.cs: 192
MEDIUM CSRF /src/Api/AdminConsole/Controllers/ProviderUsersController.cs: 62
MEDIUM CSRF /src/Api/AdminConsole/Controllers/ProviderUsersController.cs: 89
MEDIUM CSRF /src/Api/AdminConsole/Controllers/ProviderUsersController.cs: 156
MEDIUM CSRF /src/Api/AdminConsole/Controllers/ProviderUsersController.cs: 175
MEDIUM CSRF /src/Api/AdminConsole/Controllers/ProviderUsersController.cs: 188
MEDIUM CSRF /src/Api/AdminConsole/Controllers/ProvidersController.cs: 54
MEDIUM CSRF /src/Icons/Controllers/IconsController.cs: 43
MEDIUM CSRF /src/Api/Controllers/DevicesController.cs: 89
MEDIUM CSRF /src/Api/Controllers/DevicesController.cs: 100
MEDIUM CSRF /src/Api/Controllers/CollectionsController.cs: 143
MEDIUM CSRF /src/Api/Controllers/CollectionsController.cs: 171
MEDIUM CSRF /src/Api/Controllers/CollectionsController.cs: 233
MEDIUM CSRF /src/Api/AdminConsole/Controllers/EventsController.cs: 43
MEDIUM CSRF /src/Api/AdminConsole/Controllers/EventsController.cs: 88
MEDIUM CSRF /src/Api/Controllers/SelfHosted/SelfHostedOrganizationSponsorshipsController.cs: 53
MEDIUM CSRF /src/Billing/Controllers/BitPayController.cs: 57
MEDIUM CSRF /src/Identity/Controllers/SsoController.cs: 102
MEDIUM CSRF /src/Api/AdminConsole/Controllers/GroupsController.cs: 239
MEDIUM CSRF /src/Api/AdminConsole/Controllers/GroupsController.cs: 252
MEDIUM CSRF /src/Api/AdminConsole/Controllers/GroupsController.cs: 269
MEDIUM CSRF /src/Billing/Controllers/PayPalController.cs: 52
MEDIUM CSRF /src/Api/AdminConsole/Public/Controllers/EventsController.cs: 40
MEDIUM CSRF /src/Api/SecretsManager/Controllers/ProjectsController.cs: 112
MEDIUM CSRF /src/Api/SecretsManager/Controllers/ProjectsController.cs: 69
MEDIUM CSRF /src/Api/SecretsManager/Controllers/ProjectsController.cs: 51
MEDIUM CSRF /src/Api/SecretsManager/Controllers/SecretsController.cs: 201
MEDIUM CSRF /src/Api/AdminConsole/Controllers/ProviderOrganizationsController.cs: 61
MEDIUM CSRF /src/Api/AdminConsole/Controllers/ProviderOrganizationsController.cs: 73
MEDIUM CSRF /src/Api/AdminConsole/Controllers/ProviderOrganizationsController.cs: 94
MEDIUM CSRF /src/Identity/Controllers/SsoController.cs: 143
MEDIUM CSRF /src/Api/Vault/Controllers/SyncController.cs: 76
MEDIUM CSRF /src/Billing/Controllers/FreshsalesController.cs: 49
MEDIUM CSRF /src/Billing/Controllers/FreshdeskController.cs: 43
MEDIUM CSRF /src/Api/Vault/Controllers/FoldersController.cs: 79
MEDIUM CSRF /src/Api/Vault/Controllers/FoldersController.cs: 64
MEDIUM CSRF /src/Api/Vault/Controllers/FoldersController.cs: 54
MEDIUM CSRF /src/Api/Auth/Controllers/EmergencyAccessController.cs: 159
MEDIUM CSRF /src/Api/Auth/Controllers/EmergencyAccessController.cs: 102
MEDIUM CSRF /src/Api/Auth/Controllers/EmergencyAccessController.cs: 95
MEDIUM CSRF /src/Api/Auth/Controllers/EmergencyAccessController.cs: 81
MEDIUM CSRF /bitwarden_license/src/Scim/Controllers/v2/GroupsController.cs: 77
MEDIUM Client_DOM_Open_Redirect /src/Admin/Views/Users/Edit.cshtml: 76
MEDIUM Client_DOM_Open_Redirect /src/Admin/Views/Users/Edit.cshtml: 81
MEDIUM Client_DOM_Open_Redirect /src/Admin/Views/Users/Edit.cshtml: 61
MEDIUM SSRF /src/Billing/Controllers/FreshdeskController.cs: 44
MEDIUM SSRF /src/Billing/Controllers/FreshdeskController.cs: 144
MEDIUM SSRF /src/Billing/Controllers/FreshdeskController.cs: 44
LOW SSRF /src/Billing/Controllers/FreshdeskController.cs: 144

@codecov Codecov
Copy link
codecov bot commented Jun 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.73%. Comparing base (dcf97a5) to head (c6b28e8).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5941   +/-   ##
=======================================
  Coverage   47.73%   47.73%           
=======================================
  Files        1665     1665           
  Lines       75022    75022           
  Branches     6757     6757           
=======================================
  Hits        35811    35811           
  Misses      37751    37751           
  Partials     1460     1460

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Hinton
0