[PM-20576] OrganizationReport - Queries and Command #5983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkac-bw
reviewed
Jun 20, 2025
| [dbo].[OrganizationReport]; | ||
| GO | ||
|
|
||
| CREATE PROCEDURE [dbo].[OrganizationReport_Create] |
There was a problem hiding this comment.
I will fix this in the previous PR #5839
Since this PR depended on that - I have branched out of that PR.
rkac-bw
reviewed
Jun 20, 2025
| CREATE NONCLUSTERED INDEX [IX_OrganizationReport_OrganizationId] ON [dbo].[OrganizationReport]([OrganizationId] ASC); | ||
|
|
||
| CREATE NONCLUSTERED INDEX [IX_OrganizationReport_OrganizationId_Date] ON [dbo].[OrganizationReport]([OrganizationId] ASC, [Date] DESC); | ||
|
|
There was a problem hiding this comment.
will want to check for existence
IF NOT EXISTS (
SELECT 1
FROM sys.indexes
WHERE name = 'IX_OrganizationReport_OrganizationId'
AND object_id = OBJECT_ID('dbo.OrganizationReport')
)
BEGIN
CREATE NONCLUSTERED INDEX [IX_OrganizationReport_OrganizationId]
ON [dbo].[OrganizationReport]([OrganizationId] ASC);
END
GO
IF NOT EXISTS (
SELECT 1
FROM sys.indexes
WHERE name = 'IX_OrganizationReport_OrganizationId_Date'
AND object_id = OBJECT_ID('dbo.OrganizationReport')
)
BEGIN
CREATE NONCLUSTERED INDEX [IX_OrganizationReport_OrganizationId_Date]
ON [dbo].[OrganizationReport]([OrganizationId] ASC, [Date] DESC);
END
GO
There was a problem hiding this comment.
I figured that if the table is being created, the indexes shouldn't already exist. Therefore, I didn't do this check.
… into dirt/pm-20576/report-store-query-commands
prograhamming
previously approved these changes
Jun 23, 2025
ttalty
approved these changes
Jun 24, 2025
|
prograhamming
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-20576
📔 Objective
An earlier PR created a table called
OrganizationReport.This tasks involves creating the commands and queries to Add, Get, Drop records to that table - with unit tests.
📸 Screenshots
No screenshots at this moment.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes