This repository was archived by the owner on Feb 7, 2024. It is now read-only.
Add templating to service manifests #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c6e5642 to
1ba75ba
Compare
1ba75ba to
933dda6
Compare
n0rad
reviewed
Aug 21, 2017
| var err error | ||
| var manifest []byte | ||
|
|
||
| manifestPath := s.path + PATH_SERVICE_MANIFEST |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My take on solving #51.
To simplify the promblem it requires that the templates are still valid YAML.
The
Service.manifestis at first read without rendering, then if the user specifies an action that requires the unit.tmpl to be rendered, it'll trigger a rendering of the service manifest.This requires a PR on
dgr/bin-templaterthough, which is incoming ;)