chore: upgrade tough-cookie #4725
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for bloom-public-seeds ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for partners-bloom-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-exygy-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
174ce62 to
dd9a27b
Compare
dd9a27b to
394266c
Compare
ludtkemorgan
pushed a commit
to metrotranscom/doorway
that referenced
this pull request
Jun 4, 2025
ludtkemorgan
pushed a commit
to metrotranscom/doorway
that referenced
this pull request
Jun 5, 2025
9 tasks
emilyjablonski
added a commit
to housingbayarea/bloom
that referenced
this pull request
Jun 10, 2025
emilyjablonski
added a commit
to housingbayarea/bloom
that referenced
this pull request
Jun 12, 2025
ludtkemorgan
pushed a commit
to metrotranscom/doorway
that referenced
this pull request
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to metrotranscom#1132 and metrotranscom#1156
Description
We use tough-cookie to manage sending cookies to the backend from public/partners.
The breaking changes in 5 were from migrating the project to Typescript, having a minimum supported node version of 18, and no longer supporting non-node environments, none of which affects us.
For the helper package, the breaking change in version 5 was to remove support for node 14/16, which does not affect us.
How Can This Be Tested/Reviewed?
To test that there were no cookie changes, I checked out the cookie in the Application tab in the dev tools with signing in/out.
Author Checklist:
yarn generate:clientand/or created a migration when requiredReview Process: