fix: local docker updates and type fixes #4827
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for bloom-public-seeds ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for partners-bloom-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-exygy-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
seanmalbert
commented
Apr 22, 2025
wize73-ai
approved these changes
Apr 22,
8000
2025
emaliewebb
approved these changes
Apr 22, 2025
emaliewebb
approved these changes
Apr 22, 2025
1 task
c9faefb to
8013aa0
Compare
8013aa0 to
3895511
Compare
✅ Deploy Preview for bloom-lakeview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
1d887af to
fb65067
Compare
fb65067 to
eb25d4c
Compare
2120715 to
2d01228
Compare
mcgarrye
reviewed
Jun 19, 2025
| @@ -1,29 +1,74 @@ | |||
| import { randomUUID } from 'node:crypto'; | |||
There was a problem hiding this comment.
nitpick: everywhere else we import, it's just from 'crypto'
|
Does this docker setup all for the docker files to pickup live development changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #4698 specifically #4998
Description
This PR adds the ability to run Bloom Housing via docker with docker compose. While setting this up, I updated the prisma version, which allowed me to encounter two bugs that were earlier surfaced by a JTC fellow: a type errors in api/src/services/auth.service.ts and api/src/utilities/model-fields.ts.
How Can This Be Tested/Reviewed?
Instructions for using this docker locally can be found in
docker.mdThis was only tested on my computer which is an M2 mac. Follow the instructions in
docker.mdto run both just the postgres instance and all applications.For people that run into the same mac issues I had take note of the env variable changes required:
DATABASE_URL=postgresql://postgres:prisma@docker.for.mac.host.internal:5433/bloom_prismain the api .env fileBACKEND_API_BASE=http://docker.for.mac.host.internal:3100in the public and partners .env filesAuthor Checklist:
yarn generate:clientand/or created a migration when requiredReview Process: