feat: adds ui load tester & getStaticProps from getServerSideProps #4882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for partners-bloom-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-public-seeds ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-exygy-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ludtkemorgan
approved these changes
May 22, 2025
|
@YazeedLoonat Do you mind just adding a bit more documentation on running the script in the areas we had questions about pre-merge? |
✅ Deploy Preview for bloom-lakeview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
1a3d2f6 to
2526bcb
Compare
YazeedLoonat
added a commit
to housingbayarea/bloom
that referenced
this pull request
Jun 2, 2025
…loom-housing#4882) * feat: adds ui load tester & getStaticProps from getServerSideProps * fix: updates per comments * fix: updates per prs
YazeedLoonat
added a commit
to metrotranscom/doorway
that referenced
this pull request
Jun 2, 2025
…loom-housing#4882) * feat: adds ui load tester & getStaticProps from getServerSideProps * fix: updates per comments * fix: updates per prs
YazeedLoonat
added a commit
to housingbayarea/bloom
that referenced
this pull request
Jun 3, 2025
…loom-housing#4882) * feat: adds ui load tester & getStaticProps from getServerSideProps * fix: updates per comments * fix: updates per prs
YazeedLoonat
added a commit
to metrotranscom/doorway
that referenced
this pull request
Jun 9, 2025
…loom-housing#4882) * feat: adds ui load tester & getStaticProps from getServerSideProps * fix: updates per comments * fix: updates per prs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses metrotranscom#1271
Description
This adds a ui load tester script
more importantly, this changes how we get listing data for the public listing detail page from
getServerSidePropstogetStaticPropsthis should mean that instead of the server generating the HTML for the public listing detail page each time it generates it once then holds onto it for 30 seconds before rebuilding itHow Can This Be Tested/Reviewed?
Stand up the public site locally and verify you can hit the listing detail page
Aim the load tester at your listing detail page and make sure it stands up to most load tests (it'll break down at higher ends still)
Author Checklist:
yarn generate:clientand/or created a migration when requiredReview Process: