8000 fix: update navbar to match jurisdiction color by matzduniuk · Pull Request #4914 · bloom-housing/bloom · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: update navbar to match jurisdiction color #4914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 3, 2025
Merged

fix: update navbar to match jurisdiction color #4914

merged 3 commits into from
Jun 3, 2025

Conversation

matzduniuk
Copy link
Collaborator

This PR addresses #4897

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

  • Set the applications process progress navbar color override to match the jurisdictions

How Can This Be Tested/Reviewed?

  • Set app Jurisdiction to Bloomington
  • Go to /listings and start the online application process
  • The navigation progress bar should be in the jurisdiction color (in this case, blue)
  • Switch application jurisdiction to Lakeview
  • Repeat the application process
  • The navigation progress bar should match the new jurisdiction color (in this case, purple)

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

@matzduniuk matzduniuk self-assigned this Jun 2, 2025
@netlify Netlify
Copy link
netlify bot commented Jun 2, 2025 •
edited
Loading

✅ Deploy Preview for bloom-public-seeds ready!

Name Link
🔨 Latest commit ca55629
🔍 Latest deploy log https://app.netlify.com/projects/bloom-public-seeds/deploys/683eaa274c69b6000899b45d
😎 Deploy Preview https://deploy-preview-4914--bloom-public-seeds.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify Netlify
Copy link
netlify bot commented Jun 2, 2025 •
edited
Loading

✅ Deploy Preview for partners-bloom-dev ready!

Name Link
🔨 Latest commit ca55629
🔍 Latest deploy log https://app.netlify.com/projects/partners-bloom-dev/deploys/683eaa279c6e7500083cd4ed
😎 Deploy Preview https://deploy-preview-4914--partners-bloom-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify Netlify
Copy link
netlify bot commented Jun 2, 2025 •
edited
Loading

✅ Deploy Preview for bloom-exygy-dev ready!

Name Link
🔨 Latest commit ca55629
🔍 Latest deploy log https://app.netlify.com/projects/bloom-exygy-dev/deploys/683eaa2755df1e000824cc78
😎 Deploy Preview https://deploy-preview-4914--bloom-exygy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify Netlify
Copy link
netlify bot commented Jun 2, 2025 •
edited
Loading

✅ Deploy Preview for bloom-lakeview ready!

Name Link
🔨 Latest commit ca55629
🔍 Latest deploy log https://app.netlify.com/projects/bloom-lakeview/deploys/683eaa272af7380008ee8c63
😎 Deploy Preview https://deploy-preview-4914--bloom-lakeview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@emilyjablonski emilyjablonski changed the title Fix: update navbar to match jurisdiction color fix: update navbar to match jurisdiction color Jun 2, 2025
emilyjablonski
emilyjablonski approved these changes Jun 2, 2025
View reviewed changes
Copy link
Collaborator
@emilyjablonski emilyjablonski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fab

@emilyjablonski emilyjablonski added the ready to merge Should be applied when a PR has been reviewed and approved label Jun 2, 2025
@matzduniuk matzduniuk merged commit 9d343d2 into main Jun 3, 2025
29 checks passed
@matzduniuk matzduniuk deleted the 4897/update-navbar-color branch June 3, 2025 08:46
ludtkemorgan pushed a commit to metrotranscom/doorway that referenced this pull request Jun 4, 2025
@matzduniuk @emilyjablonski @ludtkemorgan
chore: override progress navbar colors to match the jurisdiction (blo…
4e13773 
…om-housing#4914)

Co-authored-by: Emily Jablonski <65367387+emilyjablonski@users.noreply.github.com>
ludtkemorgan pushed a commit to metrotranscom/doorway that referenced this pull request Jun 5, 2025
@matzduniuk @emilyjablonski @ludtkemorgan
chore: override progress navbar colors to match the jurisdiction (blo…
dc0bdd3 
…om-housing#4914)

Co-authored-by: Emily Jablonski <65367387+emilyjablonski@users.noreply.github.com>
matzduniuk added a commit to housingbayarea/bloom that referenced this pull request Jun 5, 2025
@matzduniuk @emilyjablonski
chore: override progress navbar colors to match the jurisdiction (blo…
9b2de54 
…om-housing#4914)

Co-authored-by: Emily Jablonski <65367387+emilyjablonski@users.noreply.github.com>
@ludtkemorgan ludtkemorgan mentioned this pull request Jun 5, 2025
Open
9 tasks
matzduniuk added a commit to housingbayarea/bloom that referenced this pull request Jun 11, 2025
@matzduniuk @emilyjablonski
chore: override progress navbar colors to match the jurisdiction (blo…
eba9fb7 
…om-housing#4914) (#914)

Co-authored-by: Emily Jablonski <65367387+emilyjablonski@users.noreply.github.com>
ludtkemorgan pushed a commit to metrotranscom/doorway that referenced this pull request Jun 18, 2025
@matzduniuk @emilyjablonski @ludtkemorgan
chore: override progress navbar colors to match the jurisdiction (blo…
65f3e6c 
…om-housing#4914)

Co-authored-by: Emily Jablonski <65367387+emilyjablonski@users.noreply.github.com>
< 66FD div id="issue-comment-box">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilyjablonski emilyjablonski emilyjablonski approved these changes

Assignees

@matzduniuk matzduniuk

Labels
ready to merge Should be applied when a PR has been reviewed and approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matzduniuk @emilyjablonski
0