8000 feat: update card footers in Common App to use new styles by jaredcwhite · Pull Request #4926 · bloom-housing/bloom · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: update card footers in Common App to use new styles #4926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 3, 2025

Conversation

jaredcwhite
Copy link
Collaborator

This PR addresses #4894

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

This switches over to using the same footer style as the layout that's typically used for the Common App steps.

How Can This Be Tested/Reviewed?

The easiest way is to manually set --seeds-color-primary-lighter on <html> to something obvious like yellow, then step through the app steps and make sure all the footers are consistent.

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

@jaredcwhite jaredcwhite requested a review from ColinBuyck June 2, 2025 20:23
@jaredcwhite jaredcwhite added the 1 review needed Requires 1 more review before ready to merge label Jun 2, 2025
Copy link
netlify bot commented Jun 2, 2025

Deploy Preview for partners-bloom-dev ready!

Name Link
🔨 Latest commit eba99bc
🔍 Latest deploy log https://app.netlify.com/projects/partners-bloom-dev/deploys/683f3411e9e76d0008161e6a
😎 Deploy Preview https://deploy-preview-4926--partners-bloom-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
netlify bot commented Jun 2, 2025

Deploy Preview for bloom-lakeview ready!

Name Link
🔨 Latest commit eba99bc
🔍 Latest deploy log https://app.netlify.com/projects/bloom-lakeview/deploys/683f3411913a45000807a6db
😎 Deploy Preview https://deploy-preview-4926--bloom-lakeview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
netlify bot commented Jun 2, 2025

Deploy Preview for bloom-exygy-dev ready!

Name Link
🔨 Latest commit eba99bc
🔍 Latest deploy log https://app.netlify.com/projects/bloom-exygy-dev/deploys/683f3411e304a50008848ec6
😎 Deploy Preview https://deploy-preview-4926--bloom-exygy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
netlify bot commented Jun 2, 2025

Deploy Preview for bloom-public-seeds ready!

Name Link
🔨 Latest commit eba99bc
🔍 Latest deploy log https://app.netlify.com/projects/bloom-public-seeds/deploys/683f3411913a45000807a6d9
😎 Deploy Preview https://deploy-preview-4926--bloom-public-seeds.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Collaborator
@emilyjablonski emilyjablonski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Tested using Lakeview 🟣

@emilyjablonski emilyjablonski added ready to merge Should be applied when a PR has been reviewed and approved and removed 1 review needed Requires 1 more review before ready to merge labels Jun 3, 2025
@jaredcwhite jaredcwhite merged commit c84db55 into main Jun 3, 2025
28 of 29 checks passed
@jaredcwhite jaredcwhite deleted the 4894/card-footer-backgrounds branch June 3, 2025 17:57
ludtkemorgan pushed a commit to metrotranscom/doorway that referenced this pull request Jun 4, 2025
…ing#4926)

Co-authored-by: Emily Jablonski <65367387+emilyjablonski@users.noreply.github.com>
ludtkemorgan pushed a commit to metrotranscom/doorway that referenced this pull request Jun 5, 2025
…ing#4926)

Co-authored-by: Emily Jablonski <65367387+emilyjablonski@users.noreply.github.com>
ludtkemorgan pushed a commit to metrotranscom/doorway that referenced this pull request Jun 18, 2025
…ing#4926)

Co-authored-by: Emily Jablonski <65367387+emilyjablonski@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Should be applied when a PR has been reviewed and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0