-
Notifications
You must be signed in to change notification settings - Fork 35
feat: update card footers in Common App to use new styles #4926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for partners-bloom-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-lakeview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-exygy-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-public-seeds ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Tested using Lakeview 🟣
…ing#4926) Co-authored-by: Emily Jablonski <65367387+emilyjablonski@users.noreply.github.com>
…ing#4926) Co-authored-by: Emily Jablonski <65367387+emilyjablonski@users.noreply.github.com>
…ing#4926) Co-authored-by: Emily Jablonski <65367387+emilyjablonski@users.noreply.github.com>
This PR addresses #4894
Description
This switches over to using the same footer style as the layout that's typically used for the Common App steps.
How Can This Be Tested/Reviewed?
The easiest way is to manually set
--seeds-color-primary-lighter
on<html>
to something obvious like yellow, then step through the app steps and make sure all the footers are consistent.Author Checklist:
yarn generate:client
and/or created a migration when requiredReview Process: